Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Callout, Banner, Toast colors [OKTA-750303] #2306

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

benlister-okta
Copy link
Contributor

@benlister-okta benlister-okta commented Jul 26, 2024

OKTA-750303

Summary

  • Updates Callout, Banner, and Toast colors to match recent Figma updates
  • What is different? Lighter background with an added border

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.
    CleanShot 2024-07-26 at 16 51 45@2x
    CleanShot 2024-07-26 at 16 52 09@2x

@benlister-okta benlister-okta marked this pull request as ready for review August 2, 2024 16:54
@benlister-okta benlister-okta requested a review from a team as a code owner August 2, 2024 16:54
@bryancunningham-okta
Copy link
Contributor

@benlister-okta I'm not exactly what channels this update needs to go through but, I'm pretty sure we need to make downstream teams aware of a visual update like this.

@benlister-okta
Copy link
Contributor Author

benlister-okta commented Aug 2, 2024

@benlister-okta I'm not exactly what channels this update needs to go through but, I'm pretty sure we need to make downstream teams aware of a visual update like this.

@bryancunningham-okta Definitely agree. The changes were already published in Figma a few weeks ago, so I wanted to have a PR ready with the code. It looks like Supernova hasn't been updated yet either.

@benlister-okta
Copy link
Contributor Author

Update: The plan for communicating the changes is to share an update in Slack with a visual from Alex when this is released.

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 0c746e8 into main Aug 22, 2024
3 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the bl_callout_colors branch August 22, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants